Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix draw_detection to work with batch_size > 1 #232

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix draw_detection to work with batch_size > 1 #232

wants to merge 1 commit into from
+60 −34

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Oct 28, 2024 •
edited
Loading

Fix draw_detection to work with batch_size > 1

  • atm draw_detection saves one image per batch, rather than every image.
  • this PR fixes that by returning a list instead.

TODO

  • review use of device in the visualisation function
    • in draw_detection we assign to the selected device, but then copy it back to the cpu.
  • add tests to be more comprehensive
  • refactor visualisation module

@sfmig sfmig force-pushed the smg/fix-visualisation branch from aab8622 to 83f61bb Compare October 28, 2024 17:51
This was referenced Oct 29, 2024
Merged
Closed
@sfmig sfmig mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfmig